drivers: sensor: qdec_nrfx: use standard instantiation #3418
+62
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kl-cruz
force-pushed
the
nrfx_qdec_rework
branch
3 times, most recently
from
bd6ddcc to
eefc0d6
Compare
masz-nordic
reviewed
Oct 22, 2025
| } | ||
| } | ||
|
|
||
| char const *nrfx_new_error_string_get(int code) |
There was a problem hiding this comment.
SPIM PR has been merged. Please rebase.
masz-nordic
reviewed
Oct 22, 2025
| nerr = nrfx_qdec_init(&dev_data->qdec, &config->config, qdec_nrfx_event_handler, | ||
| (void *)dev); | ||
| if (nerr != 0) { | ||
| return -EALREADY; |
There was a problem hiding this comment.
Previously this was EBUSY or EFAULT, why change that?
kl-cruz
force-pushed
the
nrfx_qdec_rework
branch
from
eefc0d6 to
9a10af7
Compare
Removed Kconfig symbols for each QDEC instance which are no longer needed. Upstream PR #: 98002 Signed-off-by: Karol Lasończyk <[email protected]>
Used API for standard instantiation and replaced nrfx_err_t error values with errno. Upstream PR #: 98002 Signed-off-by: Karol Lasończyk <[email protected]>
kl-cruz
force-pushed
the
nrfx_qdec_rework
branch
from
9a10af7 to
ca49bd2
Compare
magp-nordic
approved these changes
Oct 29, 2025
| nerr = nrfx_qdec_init(&dev_data->qdec, &config->config, qdec_nrfx_event_handler, | ||
| (void *)dev); | ||
| if (nerr != 0) { | ||
| return -EALREADY; |
There was a problem hiding this comment.
Nit: you can just return nerr in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used API for standard instantiation and replaced nrfx_err_t error values with errno.
Removed Kconfig symbols for each QDEC instance which are no longer needed.